New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve LGTM errors #44

Open

lisaychuang wants to merge 2 commits into alphagov:gh-pages from lisaychuang:lgtm-alerts

lisaychuang commented Sep 24, 2018

Resolve LGTM errors (see LGTM alert snapshot here):

Added let variable declaration in for...in statements, line 151 & line 152
Update all variable declarations from var to let

lisaychuang added 2 commits

September 24, 2018 15:10


          Resolve LGTM error with variable declaration in for...in statement. U…

94aa6aa

…pdate var to let declaration


          Resolve LGTM errors: remove unused variables, added let declarations

e42e586

Author

lisaychuang commented Sep 24, 2018

Resolve LGTM errors in analysis.js file, see LGTM alert snapshot here

Update all variable declarations from var to let
Removed unused variables: test, percent in analyse() function
Added let variable declaration in for...in statements, line 55,56,59
Added let variable declaration for tr_ew (line 107), tr_ewm (line 117)

Author

lisaychuang commented Sep 28, 2018

@selfthinker please review when you get a chance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet