Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update world location code for breaking changes in gds-api-adapters version 89.0.0 #3113

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Update world location code for breaking changes in gds-api-adapters version 89.0.0 #3113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35ebac5
Update world location code for breaking changes in `gds-api-adapters`…
brucebolt Jul 18, 2023
aef9190
Bump `gds-api-adapters` to version 89.0.0
brucebolt Jul 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ GEM
factory_bot (6.2.1)
activesupport (>= 5.0.0)
ffi (1.15.5)
gds-api-adapters (88.2.0)
gds-api-adapters (89.0.0)
addressable
link_header
null_logger
Expand Down Expand Up @@ -445,7 +445,7 @@ GEM
pry-byebug (3.10.1)
byebug (~> 11.0)
pry (>= 0.13, < 0.15)
public_suffix (5.0.1)
public_suffix (5.0.3)
puma (6.3.0)
nio4r (~> 2.0)
racc (1.7.1)
Expand Down
2 changes: 1 addition & 1 deletion app/lib/registries/world_locations_registry.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def fetch_locations
end

def fetch_locations_from_worldwide_api
Services.worldwide_api.world_locations.with_subsequent_pages.to_a
Services.worldwide_api.world_locations.to_a
end
end
end
2 changes: 1 addition & 1 deletion spec/lib/registries/world_locations_registry_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@

def world_locations_api_is_unavailable
base_url = GdsApi::TestHelpers::Worldwide::WORLDWIDE_API_ENDPOINT
stub_request(:get, "#{base_url}/api/world-locations").to_return(status: 500)
stub_request(:get, "#{base_url}/api/content/world").to_return(status: 500)
end

def clear_cache
Expand Down