Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All content finder: Dynamic filter summary text #3517

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

csutter
Copy link
Contributor

@csutter csutter commented Oct 18, 2024

This changes the text of the filter summary heading/clear all link text depending on whether the user has filters, sorting, or both active.

Examples

image image image

@govuk-ci govuk-ci temporarily deployed to finder-frontend-pr-3517 October 18, 2024 12:22 Inactive
This changes the text of the filter summary heading/clear all link text
depending on whether the user has filters, sorting, or both active.
@govuk-ci govuk-ci temporarily deployed to finder-frontend-pr-3517 October 18, 2024 12:25 Inactive
Copy link
Member

@kevindew kevindew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@csutter csutter merged commit 5517184 into main Oct 18, 2024
12 checks passed
@csutter csutter deleted the dynamic-filter-text branch October 18, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants