All content finder: Properly track empty keywords #3532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GOV.UK Analytics's `standardiseSearchTerm` returns undefined for empty queries, whereas for the `search` event we are sending, we _do_ want to keep track of the search term even if a blank string, and using undefined there will not update the state properly. Because this adds a default value for the keyword form field, we need to adjust the test for the empty field submission logic to consider the keyword present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GOV.UK Analytics's
standardiseSearchTermreturns undefined for empty queries, whereas for thesearchevent we are sending, we do want to keep track of the search term even if a blank string, and using undefined there will not update the state properly.Because this adds a default value for the keyword form field, we need to adjust the test for the empty field submission logic to consider the keyword present.