Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SortFacet: Add #sentence_fragment #3533

Merged
merged 1 commit into from
Oct 24, 2024
Merged

SortFacet: Add #sentence_fragment #3533

merged 1 commit into from
Oct 24, 2024

Conversation

csutter
Copy link
Contributor

@csutter csutter commented Oct 24, 2024

This is required for compatibility with the other ("real") facets when rendering the page as JSON or Atom.

We can safely return nil though as it's just called but not actually used in the response.

This is required for compatibility with the other ("real") facets when
rendering the page as JSON or Atom.

We can safely return nil though as it's just called but not actually
used in the response.
@govuk-ci govuk-ci temporarily deployed to finder-frontend-pr-3533 October 24, 2024 11:41 Inactive
Copy link
Member

@kevindew kevindew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May not actually need a test

@csutter csutter merged commit d2ed2a7 into main Oct 24, 2024
13 checks passed
@csutter csutter deleted the fix-feeds branch October 24, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants