Upgrade Rails to version 7.2.1 #3306

unoduetre · 2024-08-22T14:07:22Z

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

What

Upgrade government-frontend to use the latest version of Rails (7.2.1).

Why

Trello card

unoduetre · 2024-08-22T14:13:22Z

bin/brakeman

@@ -0,0 +1,7 @@
+#!/usr/bin/env ruby


Added by Rails app:update

unoduetre · 2024-08-22T14:13:55Z

bin/bundle

@@ -1,3 +1,114 @@
 #!/usr/bin/env ruby


Updating this file was suggested by Rails.

unoduetre · 2024-08-22T14:14:13Z

bin/rubocop

@@ -0,0 +1,8 @@
+#!/usr/bin/env ruby


Added in order to support the config option.

unoduetre · 2024-08-22T14:14:31Z

bin/setup

@@ -1,8 +1,8 @@
 #!/usr/bin/env ruby
 require "fileutils"

-# path to your application root.


Changes suggested by rails app:update

unoduetre · 2024-08-22T14:14:48Z

config/application.rb

+    # Please, add to the `ignore` list any other `lib` subdirectories that do
+    # not contain `.rb` files, or that should not be reloaded or eager loaded.
+    # Common ones are `templates`, `generators`, or `middleware`, for example.
+    config.autoload_lib(ignore: %w[assets tasks])


Change suggested by rails app:update

unoduetre · 2024-08-22T14:15:39Z

config/initializers/permissions_policy.rb

@@ -1,11 +1,13 @@
+# Be sure to restart your server when you modify this file.


Changes suggested by rails app:update.

unoduetre · 2024-08-22T14:15:44Z

public/404.html

@@ -4,21 +4,21 @@
  <title>The page you were looking for doesn't exist (404)</title>


Changes suggested by rails app:update.

unoduetre · 2024-08-22T14:15:56Z

public/406-unsupported-browser.html

@@ -0,0 +1,66 @@
+<!DOCTYPE html>


File added by rails app:update.

unoduetre · 2024-08-22T14:16:03Z

public/422.html

@@ -4,21 +4,21 @@
  <title>The change you wanted was rejected (422)</title>


Changes suggested by rails app:update.

unoduetre · 2024-08-22T14:16:10Z

public/500.html

@@ -4,21 +4,21 @@
  <title>We're sorry, but something went wrong (500)</title>


Changes suggested by rails app:update.

unoduetre · 2024-08-22T14:19:56Z

The default 7.2 config enables YJIT if Ruby version is at least 3.3. The current version of Ruby in this app is lower than that, but I tested this with Ruby 3.3.4.

unoduetre · 2024-08-22T15:25:04Z

config/application.rb


    # Settings in config/environments/* take precedence over those specified here.
    # Application configuration can go into files in config/initializers
    # -- all .rb files in that directory are automatically loaded after loading
    # the framework and any gems in your application.

    # Custom directories with classes and modules you want to be autoloadable.
-    config.autoload_paths += %W[#{config.root}/lib]
+    config.autoload_paths += %W[#{config.root}/lib #{config.root}/lib/helpers]


Allow /lib/helpers to be autoloaded after migrating to 7.2 config. This resolves a bug e.g. in the Heroku review app.

unoduetre · 2024-08-28T08:10:12Z

I have removed the icon files.

unoduetre · 2024-08-28T09:55:36Z

I'm updating the ticket to upgrade to 7.2.1

unoduetre · 2024-08-28T11:15:49Z

I'm updating the ticket to upgrade to 7.2.1

Done

unoduetre · 2024-09-03T10:26:57Z

config/environments/development.rb

+  config.action_controller.raise_on_missing_callback_actions = false
+
+  # Apply autocorrection by RuboCop to files generated by `bin/rails generate`.
+  config.generators.apply_rubocop_autocorrect_after_generate!


Enabled so our rubocop rules apply automatically.

beccapearce · 2024-09-13T10:34:05Z

config/environments/development.rb

@@ -52,10 +52,13 @@
  # config.i18n.raise_on_missing_translations = true

  # Annotate rendered view with file names.
-  # config.action_view.annotate_rendered_view_with_filenames = true
+  config.action_view.annotate_rendered_view_with_filenames = true


Not a blocker, but would be nice to call out why we're enabling this

It is a change suggested by app:update.

As it only applies to the development environment, it's safe to apply with no impact on tests or production.

It helps in debugging. Here is the description of what it does: https://www.bigbinary.com/blog/rails-6-1-adds-annotate_rendered_view_with_filenames-to-annotate-html-output

What is your opinion on that?

I think 'It helps in debugging.' is enough. Just so people looking back can understand why we decided to uncomment it.

Also I think this conversation is probably enough documentation too! So I think all good to be merged! 💪🏻

beccapearce

Looks good!
One non-blocking comment :)

unoduetre changed the title ~~Upgrade Rails to version 7.2~~ Upgrade Rails to version 7.2.0 Aug 22, 2024

govuk-ci temporarily deployed to government-frontend-pr-3306 August 22, 2024 14:07 Inactive

unoduetre force-pushed the upgrade-rails-to-7.2 branch from 2930f88 to 1a0ddbe Compare August 22, 2024 14:10

govuk-ci temporarily deployed to government-frontend-pr-3306 August 22, 2024 14:11 Inactive

unoduetre commented Aug 22, 2024

View reviewed changes

unoduetre force-pushed the upgrade-rails-to-7.2 branch from 1a0ddbe to ba7f53c Compare August 22, 2024 15:22

govuk-ci temporarily deployed to government-frontend-pr-3306 August 22, 2024 15:23 Inactive

unoduetre commented Aug 22, 2024

View reviewed changes

unoduetre marked this pull request as ready for review August 22, 2024 15:37

unoduetre marked this pull request as draft August 28, 2024 09:55

unoduetre force-pushed the upgrade-rails-to-7.2 branch from ba7f53c to 9144135 Compare August 28, 2024 11:15

unoduetre changed the title ~~Upgrade Rails to version 7.2.0~~ Upgrade Rails to version 7.2.1 Aug 28, 2024

govuk-ci temporarily deployed to government-frontend-pr-3306 August 28, 2024 11:15 Inactive

unoduetre force-pushed the upgrade-rails-to-7.2 branch from 9144135 to ce776d6 Compare August 28, 2024 11:16

govuk-ci temporarily deployed to government-frontend-pr-3306 August 28, 2024 11:17 Inactive

unoduetre marked this pull request as ready for review August 28, 2024 11:25

unoduetre mentioned this pull request Aug 29, 2024

Bump rails from 7.1.3.4 to 7.2.1 #3307

Closed

unoduetre force-pushed the upgrade-rails-to-7.2 branch from ce776d6 to 4a500a0 Compare August 29, 2024 13:07

govuk-ci temporarily deployed to government-frontend-pr-3306 August 29, 2024 13:07 Inactive

unoduetre force-pushed the upgrade-rails-to-7.2 branch from 4a500a0 to f9975c8 Compare August 29, 2024 13:44

govuk-ci temporarily deployed to government-frontend-pr-3306 August 29, 2024 13:45 Inactive

unoduetre force-pushed the upgrade-rails-to-7.2 branch from f9975c8 to c12cb4d Compare August 29, 2024 13:47

govuk-ci temporarily deployed to government-frontend-pr-3306 August 29, 2024 13:47 Inactive

unoduetre force-pushed the upgrade-rails-to-7.2 branch from c12cb4d to a565590 Compare August 30, 2024 16:04

govuk-ci temporarily deployed to government-frontend-pr-3306 August 30, 2024 16:05 Inactive

unoduetre commented Sep 3, 2024

View reviewed changes

unoduetre added 3 commits September 5, 2024 10:10

Upgrade Rails version to 7.2.1

ee65dfb

Update config based on rails app:update

93552ae

Enable new Rails 7.2 configuration

adc2015

unoduetre force-pushed the upgrade-rails-to-7.2 branch from a565590 to adc2015 Compare September 5, 2024 09:10

govuk-ci temporarily deployed to government-frontend-pr-3306 September 5, 2024 09:10 Inactive

beccapearce reviewed Sep 13, 2024

View reviewed changes

beccapearce approved these changes Sep 13, 2024

View reviewed changes

unoduetre merged commit 8d30342 into main Sep 13, 2024
11 checks passed

unoduetre deleted the upgrade-rails-to-7.2 branch September 13, 2024 12:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade Rails to version 7.2.1 #3306

Upgrade Rails to version 7.2.1 #3306

unoduetre commented Aug 22, 2024 •

edited

Loading

unoduetre Aug 22, 2024

unoduetre Aug 22, 2024

unoduetre Aug 22, 2024

unoduetre Aug 22, 2024

unoduetre Aug 22, 2024

unoduetre Aug 22, 2024

unoduetre Aug 22, 2024

unoduetre Aug 22, 2024

unoduetre Aug 22, 2024

unoduetre Aug 22, 2024

unoduetre commented Aug 22, 2024 •

edited

Loading

unoduetre Aug 22, 2024 •

edited

Loading

unoduetre commented Aug 28, 2024

unoduetre commented Aug 28, 2024

unoduetre commented Aug 28, 2024

unoduetre Sep 3, 2024

beccapearce Sep 13, 2024

unoduetre Sep 13, 2024

beccapearce Sep 13, 2024

beccapearce Sep 13, 2024

beccapearce left a comment

		@@ -1,11 +1,13 @@
		# Be sure to restart your server when you modify this file.

		@@ -4,21 +4,21 @@
		<title>The page you were looking for doesn't exist (404)</title>

		@@ -4,21 +4,21 @@
		<title>The change you wanted was rejected (422)</title>

		@@ -4,21 +4,21 @@
		<title>We're sorry, but something went wrong (500)</title>

Upgrade Rails to version 7.2.1 #3306

Upgrade Rails to version 7.2.1 #3306

Conversation

unoduetre commented Aug 22, 2024 • edited Loading

What

Why

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

unoduetre commented Aug 22, 2024 • edited Loading

unoduetre Aug 22, 2024 • edited Loading

Choose a reason for hiding this comment

unoduetre commented Aug 28, 2024

unoduetre commented Aug 28, 2024

unoduetre commented Aug 28, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

beccapearce left a comment

Choose a reason for hiding this comment

unoduetre commented Aug 22, 2024 •

edited

Loading

unoduetre commented Aug 22, 2024 •

edited

Loading

unoduetre Aug 22, 2024 •

edited

Loading