Skip to content

Commit

Permalink
Remove references to sg_management_id
Browse files Browse the repository at this point in the history
This was the security group that let us SSH into instances in the
pre-replatforming world.

It no longer exists, but its ID is still in the now deleted
infra-security-groups project's statefile.

None of these projects have been applied since the security group was
deleted, but clearly they've all been removed from the security group
(since it no longer exists). Or in the case of related links, they're
probably just not applied at all.

This commit at least fixes an obviously broken bit of config, making it
slightly more likely that we'd be able to apply these projects if we
wanted to.

It's enough to fix app-elasticsearch6, which is the one I care about
right now.
  • Loading branch information
richardTowers committed Jul 19, 2024
1 parent 2abee27 commit d8a5c43
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 3 deletions.
1 change: 0 additions & 1 deletion terraform/projects/app-elasticsearch6/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,6 @@ resource "aws_elasticsearch_domain" "elasticsearch6" {
)
security_group_ids = [
data.terraform_remote_state.infra_security_groups.outputs.sg_elasticsearch6_id,
data.terraform_remote_state.infra_security_groups.outputs.sg_management_id,
]
}

Expand Down
1 change: 0 additions & 1 deletion terraform/projects/app-related-links/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,6 @@ resource "aws_launch_template" "related-links-ingestion_launch-template" {

vpc_security_group_ids = [
"${data.terraform_remote_state.infra_security_groups.sg_related-links_id}",
"${data.terraform_remote_state.infra_security_groups.sg_management_id}",
]

key_name = aws_key_pair.jenkins_public_key.key_name
Expand Down
1 change: 0 additions & 1 deletion terraform/projects/app-search/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ module "search" {
instance_subnet_ids = data.terraform_remote_state.infra_networking.outputs.private_subnet_ids
instance_security_group_ids = [
data.terraform_remote_state.infra_security_groups.outputs.sg_search_id,
data.terraform_remote_state.infra_security_groups.outputs.sg_management_id
]
instance_type = var.instance_type
instance_additional_user_data = join("\n", null_resource.user_data.*.triggers.snippet)
Expand Down

0 comments on commit d8a5c43

Please sign in to comment.