Speed up the pre-merge checks. #1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sengi
force-pushed
the
sengi/faster-tests
branch
10 times, most recently
from
35b7a84
to
e2134c9
Compare
sengi
added a commit
to alphagov/govuk-saas-config
that referenced
this pull request
Nov 20, 2023
We now run the linters in parallel. - alphagov/govuk-aws#1738
sengi
force-pushed
the
sengi/faster-tests
branch
2 times, most recently
from
1db302f
to
4efe5c9
Compare
This takes the push/test cycle from around 2 minutes to under 20 seconds. Should make it a lot less painful to clean up the remaining modules in here. - Run the pre-merge checks in parallel. - Run terraform-docs in parallel. - Use Ubuntu instead of macOS runners. Reduces expected admission delay from ~20s to <5s. - Cache Terraform binaries so we don't download them every time. - Update Ruby libraries to latest versions. alphagov/govuk-saas-config#177 updates the repo config to match.
sengi
force-pushed
the
sengi/faster-tests
branch
from
4efe5c9
to
5359b86
Compare
samsimpson1
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes the push/test cycle from around 2 minutes to under 20 seconds. Should make it a lot less painful to clean up the remaining modules in here.
alphagov/govuk-saas-config#177 updates the repo config to match.
The pending
testpre-merge check on this PR is the defunct one that we're replacing.