Tag elasticsearch resources with GOV.UK - Search #1835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One slightly unfortunate gotcha here is that the Project tag (note: capital P) is already used for "blue" or "govuk" stacks, alongside the "aws_stackname" tag. Tags are case sensitive in AWS, so Project != project. project with a lower case "p" is set as a cost allocation tag, while Project with an upper case "P" is not. Having them both is probably a bit confusing, but I don't want to go too far down the rabbit hole here. Eventually we should probably just remove the Project = blue / govuk tags from everything.
sengi
approved these changes
Jul 18, 2024
samsimpson1
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One slightly unfortunate gotcha here is that the Project tag (note: capital P) is already used for "blue" or "govuk" stacks, alongside the "aws_stackname" tag.
Tags are case sensitive in AWS, so Project != project.
project with a lower case "p" is set as a cost allocation tag, while Project with an upper case "P" is not.
Having them both is probably a bit confusing, but I don't want to go too far down the rabbit hole here.
Eventually we should probably just remove the Project = blue / govuk tags from everything.