Remove references to sg_management_id #1836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was the security group that let us SSH into instances in the pre-replatforming world. It no longer exists, but its ID is still in the now deleted infra-security-groups project's statefile. None of these projects have been applied since the security group was deleted, but clearly they've all been removed from the security group (since it no longer exists). Or in the case of related links, they're probably just not applied at all. This commit at least fixes an obviously broken bit of config, making it slightly more likely that we'd be able to apply these projects if we wanted to. It's enough to fix app-elasticsearch6, which is the one I care about right now.
samsimpson1
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was the security group that let us SSH into instances in the pre-replatforming world.
It no longer exists, but its ID is still in the now deleted infra-security-groups project's statefile.
None of these projects have been applied since the security group was deleted, but clearly they've all been removed from the security group (since it no longer exists). Or in the case of related links, they're probably just not applied at all.
This commit at least fixes an obviously broken bit of config, making it slightly more likely that we'd be able to apply these projects if we wanted to.
It's enough to fix app-elasticsearch6, which is the one I care about right now.