Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce reusable action/workflow/script for commenting on PRs reusing the same comment #3545

Closed
2 tasks done
Tracked by #3544 ...
romaricpascal opened this issue Apr 25, 2023 · 0 comments · Fixed by #3571
Closed
2 tasks done
Tracked by #3544 ...
Assignees
Milestone

Comments

@romaricpascal
Copy link
Member

romaricpascal commented Apr 25, 2023

What

Create a reusable action, workflow or script that lets us post comments on Github PRs when they're created and update that initial comment when new commits are made to the PR.1

Why

We're looking to post more informations on our PRs to facilitate the reviews. This is the foundation that'll help us do so.

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

Tasks

Footnotes

  1. Besides our current diff action, the spike for surfacing performance information also does some commenting (using a JavaScript function in the hopes to lead to something more testable)

@romaricpascal romaricpascal moved this from Backlog 🗄 to Sprint Backlog 🏃🏼‍♀️ in GOV.UK Design System cycle board Apr 25, 2023
@romaricpascal romaricpascal added this to the v5.0 milestone Apr 25, 2023
@domoscargin domoscargin self-assigned this Apr 25, 2023
@domoscargin domoscargin moved this from Sprint Backlog 🏃🏼‍♀️ to In progress 📝 in GOV.UK Design System cycle board Apr 25, 2023
@domoscargin domoscargin moved this from In progress 📝 to Needs review 🔍 in GOV.UK Design System cycle board May 10, 2023
@domoscargin domoscargin moved this from Needs review 🔍 to In progress 📝 in GOV.UK Design System cycle board May 11, 2023
@domoscargin domoscargin moved this from In progress 📝 to Needs review 🔍 in GOV.UK Design System cycle board May 11, 2023
@colinrotherham colinrotherham moved this from Needs review 🔍 to Done 🏁 in GOV.UK Design System cycle board May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

2 participants