-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generic comment on PR script #3571
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
a921214
to
1be66c5
Compare
Changes to distdiff --git a/dist/govuk-frontend-4.6.0.min.css b/dist/govuk-frontend-4.6.0.min.css
index ba4a829f..74c2cf8f 100644
--- a/dist/govuk-frontend-4.6.0.min.css
+++ b/dist/govuk-frontend-4.6.0.min.css
@@ -11,7 +11,9 @@
text-decoration: underline
}
-/*! Copyright (c) 2011 by Margaret Calvert & Henrik Kubel. All rights reserved. The font has been customised for exclusive use on gov.uk. This cut is not commercially available. */
++
+
+/*! Testing comment update */
@font-face {
font-family: GDS Transport;
font-style: normal;
SHA: a5e8d77 |
2813678
to
c83d220
Compare
6e68ff0
to
6dc18c3
Compare
6dc18c3
to
c54eada
Compare
c54eada
to
3a8a922
Compare
3a8a922
to
63dcbe0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cheers for bringing that in and hunting the types to make it all proper 😊 Spotted a little issue with the last comment automatically added on this PR and got a little suggestion for the API.
From having dug a little more into this, do you think there could be a way to add automated tests to the commentOnPr
as well or would we have to maintain our own mocks of Github's API and responses for that?
63dcbe0
to
4948a3d
Compare
Changes to distdiff --git a/dist/govuk-frontend-4.6.0.min.css b/dist/govuk-frontend-4.6.0.min.css
index ba4a829f..97c3523d 100644
--- a/dist/govuk-frontend-4.6.0.min.css
+++ b/dist/govuk-frontend-4.6.0.min.css
@@ -11,7 +11,7 @@
text-decoration: underline
}
-/*! Copyright (c) 2011 by Margaret Calvert & Henrik Kubel. All rights reserved. The font has been customised for exclusive use on gov.uk. This cut is not commercially available. */
+/*! Testing new improvements 11/05/23 4.50pm */
@font-face {
font-family: GDS Transport;
font-style: normal;
SHA: 83da58c |
4948a3d
to
aafc839
Compare
7f0b449
to
00a73c2
Compare
00a73c2
to
1183bd8
Compare
51a0f8a
to
a5277d8
Compare
a5277d8
to
3b5417b
Compare
Co-authored-by: Colin Rotherham <[email protected]>
3b5417b
to
0992816
Compare
0992816
to
2183420
Compare
2183420
to
8c366e1
Compare
8c366e1
to
9adaf2d
Compare
9adaf2d
to
a5e8d77
Compare
a5e8d77
to
0b2d6cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @colinrotherham
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat one! Thanks both! ⛵
This is the MVP for a script to comment on PRs.
It can be passed the Github context, a marker string to identify which comment to target, and the content of the comment. The idea is to get this functionality into the codebase soon, then work on improvements such as:
Closes #3545