Update visually hidden class to fix ordering issue in VoiceOver OSX #1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1109
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1109
NickColley
force-pushed
the
update-visually-hidden-text-class
branch
from
5a56ad8
to
9003059
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1109
I have investigated this and recorded the results in this gist: https://gist.github.com/nickcolley/19b80ed24d0364cfd3afd3b1b49c4014 We should update the govuk-visually-hidden class to remove the negative margin which will fix the ordering issue in VoiceOver for OSX. We should recommend using aria-label or aria-labelledby where it makes sense to. Visually hidden CSS can result in text not being read out when touching on iOS, this is regrettable but does not cause a hard barrier as users can explore the surrounding content to understand context.
NickColley
force-pushed
the
update-visually-hidden-text-class
branch
from
9003059
to
376bf53
Compare
|
Thanks to @stevenaproctor and the accessibility team at HMRC for letting us know about this issue. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have investigated this and recorded the results in this gist: https://gist.github.com/nickcolley/19b80ed24d0364cfd3afd3b1b49c4014
We should update the govuk-visually-hidden class to remove the negative margin which will fix the ordering issue in VoiceOver for OSX.
We should recommend using aria-label or aria-labelledby where it makes sense to.
Visually hidden CSS can result in text not being read out when touching on iOS, this is regrettable but does not cause a hard barrier as users can explore the surrounding content to understand context.
Closes #1096