Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update info about browser support in repo docs #2628

Closed
wants to merge 1 commit into from

Conversation

EoinShaughnessy
Copy link
Contributor

Fixes #2623.

@EoinShaughnessy EoinShaughnessy added documentation User requests new documentation or improvements to existing documentation javascript javascript squad labels May 17, 2022
@EoinShaughnessy EoinShaughnessy self-assigned this May 17, 2022

We're planning to [reduce our level of support for all versions of IE](https://github.com/alphagov/govuk-frontend/discussions/2607).

In a future major release, we'll reduce the level of support for IE11 from 'compliant' to 'functional'.
Copy link
Contributor Author

@EoinShaughnessy EoinShaughnessy May 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add some detail here about what 'functional' and 'compliant' mean, or would that just repeat what's in Kim's proposal (which we're linking to)?

@EoinShaughnessy
Copy link
Contributor Author

@vanitabarrett

Line 54 (current version of doc)/line 73 (this PR) also mentions IE8:

[You should also use] a separate stylesheet if you support Internet Explorer 8

Do we need to delete/keep/change this line?

@EoinShaughnessy
Copy link
Contributor Author

EoinShaughnessy commented May 17, 2022

@vanitabarrett Also saw some other IE mentions in the repo...

https://github.com/alphagov/govuk-frontend/blob/main/docs/contributing/resize-text-in-browsers.md#resize-text-in-internet-explorer-versions-8-to-11
Should we leave this as it is for now, in case anyone wants to know how to resize text in IE? If so, should I create an issue so we know to change/remove it when the time comes (i.e., when we've reduced support)?

https://github.com/alphagov/govuk-frontend/blob/main/docs/contributing/coding-standards/css.md#use-single-colons-for-pseudo-element-selectors
Line: "This is to ensure compatibility with Internet Explorer 8, which doesn't support the double colon syntax."
Can we delete this section?

https://github.com/alphagov/govuk-frontend/blob/main/CONTRIBUTING.md#supported-browsers
Line: Your contribution needs to work with certain browsers as set out in README. See also supporting Internet Explorer 8."
Should we delete the second sentence, if the plan is to deprecate the Frontend Docs page about supporting IE8?

@36degrees
Copy link
Contributor

Our approach to browser support has changed since this PR was opened. We'll pick this up again as part of #2718.

@36degrees 36degrees closed this Apr 19, 2023
@36degrees 36degrees deleted the update-repo-docs-about-browser-support branch April 19, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation User requests new documentation or improvements to existing documentation javascript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update internal browser support documentation
3 participants