Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default link underline offset setting #3454

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Update default link underline offset setting #3454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ The [Button](https://design-system.service.gov.uk/components/button/) Nunjucks m

This was added in [pull request #3344: Adding optional id attribute to button component](https://github.com/alphagov/govuk-frontend/pull/3344). Thanks to [Tom Billington](https://github.com/TomBillingtonUK) for this contribution.

### Added a modifier for text input styles that accept sequences of digits
#### Added a modifier for text input styles that accept sequences of digits

We've added a new `.govuk-input--extra-letter-spacing` class for [Text Input](https://design-system.service.gov.uk/components/text-input/). This increases readability of text inputs that receive sequences of digits (like security codes, references or phone numbers).

Expand Down Expand Up @@ -96,6 +96,7 @@ We’ve made fixes to GOV.UK Frontend in the following pull requests:
- [#3306: Re-enable complete hover link styles on the footer](https://github.com/alphagov/govuk-frontend/pull/3306)
- [#3312: Add default value for warning text icon fallback attribute](https://github.com/alphagov/govuk-frontend/pull/3312)
- [#3426: Add organisation brand colour for Department for Business & Trade](https://github.com/alphagov/govuk-frontend/pull/3426) - thanks to [Barbara Slawinska](https://github.com/baisa) for contributing this change
- [#3454: Update default link underline offset setting](https://github.com/alphagov/govuk-frontend/pull/3454)

## 4.5.0 (Feature release)

Expand Down
6 changes: 5 additions & 1 deletion src/govuk/settings/_links.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,16 @@ $govuk-link-underline-thickness: unquote("max(1px, .0625rem)") !default;

/// Offset of link underlines from text baseline
///
/// The default is 3px expressed as ems, as calculated against the default body
/// font size (on desktop) of 19px.
/// 3 ÷ 19 = 0.1578
///
/// Set this variable to `false` to avoid setting an offset.
///
/// @type Number
/// @access public

$govuk-link-underline-offset: .1em !default;
$govuk-link-underline-offset: .1578em !default;
colinrotherham marked this conversation as resolved.
Show resolved Hide resolved

/// Thickness of link underlines in hover state
///
Expand Down