Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @percy/sdk-utils from 1.23.0 to 1.24.0 #3540

Merged
merged 2 commits into from
Apr 24, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 24, 2023

Bumps @percy/sdk-utils from 1.23.0 to 1.24.0.

Release notes

Sourced from @​percy/sdk-utils's releases.

v1.24.0

What's Changed

✨ Enhancements

🏗 Maintenance

⬆️⬇️ Dependency Updates

Full Changelog: percy/cli@v1.23.0...v1.24.0

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [@percy/sdk-utils](https://github.com/percy/cli/tree/HEAD/packages/sdk-utils) from 1.23.0 to 1.24.0.
- [Release notes](https://github.com/percy/cli/releases)
- [Commits](https://github.com/percy/cli/commits/v1.24.0/packages/sdk-utils)

---
updated-dependencies:
- dependency-name: "@percy/sdk-utils"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript labels Apr 24, 2023
@dependabot dependabot bot requested a review from a team April 24, 2023 12:11
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3540 April 24, 2023 12:11 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3540 April 24, 2023 14:03 Inactive
@romaricpascal romaricpascal force-pushed the dependabot/npm_and_yarn/percy/sdk-utils-1.24.0 branch from 27b2b87 to 513dc8b Compare April 24, 2023 14:07
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3540 April 24, 2023 14:07 Inactive
@@ -33,5 +32,8 @@
"slash": "^5.0.0",
"terser": "^5.17.1",
"yargs-parser": "^21.1.1"
},
"dependencies": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@romaricpascal Mind if we keep this as a devDependency?

You probably wanted --save-dev not --save when fixing

Otherwise all the workspaces that import govuk-frontend-tasks will install it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, forgot to check which kind of dependency it was before running the command , sorry 🤦🏻 I'll fix that 😊

Copy link
Contributor

@colinrotherham colinrotherham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just going to request changes before we merge this one

@romaricpascal romaricpascal force-pushed the dependabot/npm_and_yarn/percy/sdk-utils-1.24.0 branch from 513dc8b to b0ee3b2 Compare April 24, 2023 14:16
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3540 April 24, 2023 14:16 Inactive
@romaricpascal romaricpascal force-pushed the dependabot/npm_and_yarn/percy/sdk-utils-1.24.0 branch from b0ee3b2 to f22b757 Compare April 24, 2023 14:16
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3540 April 24, 2023 14:17 Inactive
@romaricpascal romaricpascal merged commit d513b97 into main Apr 24, 2023
@romaricpascal romaricpascal deleted the dependabot/npm_and_yarn/percy/sdk-utils-1.24.0 branch April 24, 2023 14:41
@colinrotherham
Copy link
Contributor

colinrotherham commented Apr 24, 2023

For context, this one hit a Dependabot issue we caught with npm ls --depth=0

Fixed with:

npm uninstall @percy/sdk-utils --workspace shared/tasks
npm install @percy/sdk-utils --workspace shared/tasks --save-dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript
Projects
Development

Successfully merging this pull request may close these issues.

3 participants