-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw ElementError
when the module is not of the expected type
#4104
Conversation
893d9f5
to
e99db36
Compare
e99db36
to
00921cd
Compare
f56b352
to
ea136f7
Compare
ea136f7
to
45e90c8
Compare
packages/govuk-frontend/src/govuk/components/skip-link/skip-link.mjs
Outdated
Show resolved
Hide resolved
I agree that the generic types approach seems neater and less prone to error here. I guess we could also make the |
8797d32
to
fa02f52
Compare
📋 StatsFile sizes
Modules
View stats and visualisations on the review app Action run for 655af8f |
fa02f52
to
cfa57fb
Compare
cfa57fb
to
f1f858e
Compare
f1f858e
to
eabdc84
Compare
@colinrotherham @domoscargin Ready for re-review, simplified implementation by replacing the |
|
eabdc84
to
daa1e52
Compare
Make each component throw a
TypeError
when the$module
it receives is not of the type it needs to function properly.Closes #4035.