Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Dependabot ignore eslint and eslint-* #4999

Merged
merged 1 commit into from
May 23, 2024

Conversation

patrickpatrickpatrick
Copy link
Contributor

@patrickpatrickpatrick patrickpatrickpatrick commented May 23, 2024

What

Adds eslint and eslint-* to packages that Dependabot should ignore.

Why

Dependabot keeps timing out before completing (issue #4982) and on inspection of the logs, it appears that the last package it attempts to install is eslint-plugin-n. Attempting to install this package locally results in a peer dependency error. As we are currently waiting to update eslint and it's associated plugins to their latest versions, it makes sense to stop Dependabot from updating eslint and associated plugins until we can update them all at once.

(Perhaps) addresses #4982

@patrickpatrickpatrick patrickpatrickpatrick changed the title ignore eslint for now Make Dependabot ignore eslint and eslint-* packages May 23, 2024
Copy link

github-actions bot commented May 23, 2024

📋 Stats

File sizes

File Size
dist/govuk-frontend-development.min.css 113.37 KiB
dist/govuk-frontend-development.min.js 42.34 KiB
packages/govuk-frontend/dist/govuk/all.bundle.js 88.16 KiB
packages/govuk-frontend/dist/govuk/all.bundle.mjs 82.83 KiB
packages/govuk-frontend/dist/govuk/all.mjs 981 B
packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs 359 B
packages/govuk-frontend/dist/govuk/govuk-frontend.min.css 113.36 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend.min.js 42.33 KiB
packages/govuk-frontend/dist/govuk/i18n.mjs 5.55 KiB
packages/govuk-frontend/dist/govuk/init.mjs 4.86 KiB

Modules

File Size (bundled) Size (minified)
all.mjs 78.45 KiB 40.31 KiB
accordion.mjs 22.71 KiB 12.85 KiB
button.mjs 5.98 KiB 2.69 KiB
character-count.mjs 22.4 KiB 9.92 KiB
checkboxes.mjs 5.83 KiB 2.83 KiB
error-summary.mjs 7.89 KiB 3.46 KiB
exit-this-page.mjs 17.1 KiB 9.26 KiB
header.mjs 4.46 KiB 2.6 KiB
notification-banner.mjs 6.26 KiB 2.62 KiB
password-input.mjs 15.15 KiB 7.25 KiB
radios.mjs 4.83 KiB 2.38 KiB
skip-link.mjs 4.39 KiB 2.18 KiB
tabs.mjs 10.13 KiB 6.11 KiB

View stats and visualisations on the review app


Action run for 2a929e9

@patrickpatrickpatrick patrickpatrickpatrick changed the title Make Dependabot ignore eslint and eslint-* packages Make Dependabot ignore eslint and eslint-* May 23, 2024
Dependabot keeps timing out before completing and on inspection of the
logs, the latest package it attempts to install is `eslint-plugin-n`.
This commit makes Dependabot ignore the eslint packages until we are
able to update them all, as this is currently blocked by not all the
plugins supporting the latest version of the `eslint` config.
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4999 May 23, 2024 14:17 Inactive
@patrickpatrickpatrick patrickpatrickpatrick requested a review from a team May 23, 2024 14:23
Copy link
Member

@romaricpascal romaricpascal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give this a spin. ⛵

After merge, let's try and trigger a dependabot run from the web UI.

@patrickpatrickpatrick patrickpatrickpatrick merged commit d0879e6 into main May 23, 2024
49 checks passed
@patrickpatrickpatrick patrickpatrickpatrick deleted the ignore-style-lint branch May 23, 2024 15:04
@romaricpascal romaricpascal linked an issue May 24, 2024 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Dependabot timing out
3 participants