This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
Remove ASSET_HOST for Static #11801
Merged
Remove ASSET_HOST for Static #11801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theseanything
added a commit
to alphagov/collections
that referenced
this pull request
Sep 1, 2022
This sets the GOVUK_PROXY_STATIC_URL env var to enable the proxy to Static in production. This is so the application continues, when Static changes to use relative URLs for assets. See alphagov/govuk_app_config#261 and alphagov/govuk-puppet#11801
theseanything
added a commit
to alphagov/collections
that referenced
this pull request
Sep 1, 2022
This sets the GOVUK_PROXY_STATIC_ENABLED env var to enable the proxy to Static in production. This is so the application continues, when Static changes to use relative URLs for assets. See alphagov/govuk_app_config#261 and alphagov/govuk-puppet#11801
This was referenced Sep 1, 2022
theseanything
added a commit
to alphagov/finder-frontend
that referenced
this pull request
Sep 1, 2022
This sets the GOVUK_PROXY_STATIC_ENABLED env var to enable the proxy to Static in production. This is so the application continues, when Static changes to use relative URLs for assets. See alphagov/govuk_app_config#261 and alphagov/govuk-puppet#11801
theseanything
added a commit
to alphagov/frontend
that referenced
this pull request
Sep 1, 2022
This sets the GOVUK_PROXY_STATIC_ENABLED env var to enable the proxy to Static in production. This is so the application continues, when Static changes to use relative URLs for assets. See alphagov/govuk_app_config#261 and alphagov/govuk-puppet#11801
theseanything
added a commit
to alphagov/government-frontend
that referenced
this pull request
Sep 1, 2022
This sets the GOVUK_PROXY_STATIC_ENABLED env var to enable the proxy to Static in production. This is so the application continues, when Static changes to use relative URLs for assets. See alphagov/govuk_app_config#261 and alphagov/govuk-puppet#11801
theseanything
added a commit
to alphagov/info-frontend
that referenced
this pull request
Sep 1, 2022
This sets the GOVUK_PROXY_STATIC_ENABLED env var to enable the proxy to Static in production. This is so the application continues, when Static changes to use relative URLs for assets. See alphagov/govuk_app_config#261 and alphagov/govuk-puppet#11801
theseanything
added a commit
to alphagov/licence-finder
that referenced
this pull request
Sep 1, 2022
This sets the GOVUK_PROXY_STATIC_ENABLED env var to enable the proxy to Static in production. This is so the application continues, when Static changes to use relative URLs for assets. See alphagov/govuk_app_config#261 and alphagov/govuk-puppet#11801
theseanything
added a commit
to alphagov/service-manual-frontend
that referenced
this pull request
Sep 1, 2022
This sets the GOVUK_PROXY_STATIC_ENABLED env var to enable the proxy to Static in production. This is so the application continues, when Static changes to use relative URLs for assets. See alphagov/govuk_app_config#261 and alphagov/govuk-puppet#11801
theseanything
added a commit
to alphagov/smart-answers
that referenced
this pull request
Sep 1, 2022
This sets the GOVUK_PROXY_STATIC_ENABLED env var to enable the proxy to Static in production. This is so the application continues, when Static changes to use relative URLs for assets. See alphagov/govuk_app_config#261 and alphagov/govuk-puppet#11801
theseanything
added a commit
to alphagov/govuk-docker
that referenced
this pull request
Sep 1, 2022
This sets the GOVUK_PROXY_STATIC_ENABLED env var to enable the proxy to Static in production. This is so the application continues, when Static changes to use relative URLs for assets. See alphagov/govuk_app_config#261 and alphagov/govuk-puppet#11801
By removing ASSET_HOST assets URLs and compiled asset URLs (e.g. in css) will become relative. This works as assets are served from the same domain in production (however with the path prefix /assets/static/*). Having ASSET_HOST set and using absolute URLs prevents us creating re-usable container images, as the assets URLs are environment dependent. We set ASSET_HOST for Static so that local development and heroku deployments can send requests to Static hosted in Production, instead of running a local version. However, this problem can be solved by proxing requests via the frontend app.
theseanything
force-pushed
the
remove-asset-host-for-static
branch
from
aaae79c
to
ba498b0
Compare
sengi
approved these changes
Sep 6, 2022
|
Turns out this was a load-bearing piece of tech debt 😭🤣🙈 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By removing ASSET_HOST assets URLs and compiled asset URLs (e.g. in
css) will become relative. This works as assets are served from the same
domain in production (however with the path prefix /assets/static/*).
Having ASSET_HOST set and using absolute URLs prevents us creating re-usable
container images, as the assets URLs are environment dependent.
We set ASSET_HOST for Static so that local development and heroku
deployments can send requests to Static hosted in Production, instead of
running a local version. However, this problem can be solved by proxing
requests via the frontend app.