Merge pull request #142 from alphagov/rescue-more-errors

Exclude ActiveRecord rescue responses
alphagov · Mar 19, 2020 · 0c813be · 0c813be
2 parents 9344834 + fe0f460
commit 0c813be
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,10 @@
+# Unreleased
+
+* Add missing ActiveRecord rescue_responses (https://github.com/alphagov/govuk_app_config/pull/142)
+
 # 2.1.1
 
-* Revert using Sentry option of rails_report_rescued_exceptions (https://github.com/alphagov/govuk_app_config/pull/140)
+* Revert using sentry option of rails_report_rescued_exceptions (https://github.com/alphagov/govuk_app_config/pull/140)
 
 # 2.1.0
 

diff --git a/lib/govuk_app_config/configure.rb b/lib/govuk_app_config/configure.rb
@@ -8,7 +8,7 @@
   config.silence_ready = !Rails.env.production? if defined?(Rails)
 
   config.excluded_exceptions = [
-    # default Rails rescue responses
+    # Default ActionDispatch rescue responses
     "ActionController::RoutingError",
     "AbstractController::ActionNotFound",
     "ActionController::MethodNotAllowed",
@@ -24,7 +24,12 @@
     "ActionController::ParameterMissing",
     "Rack::QueryParser::ParameterTypeError",
     "Rack::QueryParser::InvalidParameterError",
-    # additional items
+    # Default ActiveRecord rescue responses
+    "ActiveRecord::RecordNotFound",
+    "ActiveRecord::StaleObjectError",
+    "ActiveRecord::RecordInvalid",
+    "ActiveRecord::RecordNotSaved",
+    # Additional items
     "ActiveJob::DeserializationError",
     "CGI::Session::CookieStore::TamperedWithCookie",
     "GdsApi::HTTPIntermittentServerError",