Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude ActiveRecord rescue responses #142

Merged
merged 2 commits into from
Mar 19, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
# Unreleased

* Add missing ActiveRecord rescue_responses (https://github.com/alphagov/govuk_app_config/pull/142)

# 2.1.1

* Revert using Sentry option of rails_report_rescued_exceptions (https://github.com/alphagov/govuk_app_config/pull/140)
* Revert using sentry option of rails_report_rescued_exceptions (https://github.com/alphagov/govuk_app_config/pull/140)

# 2.1.0

Expand Down
9 changes: 7 additions & 2 deletions lib/govuk_app_config/configure.rb
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
config.silence_ready = !Rails.env.production? if defined?(Rails)

config.excluded_exceptions = [
# default Rails rescue responses
# Default ActionDispatch rescue responses
"ActionController::RoutingError",
"AbstractController::ActionNotFound",
"ActionController::MethodNotAllowed",
Expand All @@ -24,7 +24,12 @@
"ActionController::ParameterMissing",
"Rack::QueryParser::ParameterTypeError",
"Rack::QueryParser::InvalidParameterError",
# additional items
# Default ActiveRecord rescue responses
"ActiveRecord::RecordNotFound",
"ActiveRecord::StaleObjectError",
"ActiveRecord::RecordInvalid",
"ActiveRecord::RecordNotSaved",
# Additional items
"ActiveJob::DeserializationError",
"CGI::Session::CookieStore::TamperedWithCookie",
"GdsApi::HTTPIntermittentServerError",
Expand Down