Add a couple of new healthchecks #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 13, 2020 10:57
This is used in place of ActiveRecord quite a few of our apps [1]. Note that the check is pinched from the Internet [2]. [1]: alphagov/travel-advice-publisher#973 [2]: https://stackoverflow.com/questions/28446274/how-can-i-check-the-connection-of-mongoid
We use a local Memcached instance for the cache store in several of our apps [1] [2]. If the cache is unavailable, it will print error logs but an exception won't be thrown. While the behaviour is graceful, it's still a problem that the caching we rely on is not working as expected, so we should surface this in healthchecks. [1]: https://github.com/alphagov/collections/blob/a08857d95771e813338fbbe8542a8f5b536ea6d4/config/environments/production.rb#L58 [2]: https://github.com/alphagov/whitehall/blob/774eb78cd4c75622e786bdb18762850cd0b91840/config/environments/production.rb#L61
benthorner
force-pushed
the
new-healthchecks
branch
from
6a020a2
to
972066d
Compare
This has arisen due to a mismatch in the version of rubocop-ast.
benthorner
force-pushed
the
new-healthchecks
branch
from
5a5397f
to
985cfdb
Compare
This is causing the build to break when testing against Ruby 2.7, and isn't something we have in our other gems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/epNWudCR/176-write-an-rfc-for-continuous-deployment-and-seek-review
Please see the commits for more details.