Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add govuk_app_config version to every sentry call #174

Merged
merged 1 commit into from
Dec 4, 2020
Merged

Add govuk_app_config version to every sentry call #174

merged 1 commit into from
Dec 4, 2020

Conversation

benjamineskola
Copy link
Contributor

@benjamineskola benjamineskola force-pushed the sentry-send-version branch 4 times, most recently from d962928 to e373cbe Compare December 3, 2020 16:12
@AlanGabbianelli
Copy link
Contributor

This looks good @benjamineskola 👍 Can you please add some context in the commit message on why this is needed?

ChrisBAshton
ChrisBAshton approved these changes Dec 4, 2020
View reviewed changes
Copy link
Contributor

@ChrisBAshton ChrisBAshton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, Ben - thanks! 👏

@benjamineskola benjamineskola merged commit 102a389 into master Dec 4, 2020
@benjamineskola benjamineskola deleted the sentry-send-version branch December 4, 2020 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisBAshton ChrisBAshton ChrisBAshton approved these changes

@AlanGabbianelli AlanGabbianelli AlanGabbianelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benjamineskola @AlanGabbianelli @ChrisBAshton