Adds plural rules not available in i18n #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
reviewed
Mar 18, 2021
lib/govuk_app_config/govuk_i18n.rb
Outdated
| @@ -0,0 +1,36 @@ | |||
| module GovukI18n | |||
| { | |||
There was a problem hiding this comment.
I wonder if we should give this an explicit name such as
def plurals
...
endor
PLURALS = ...Otherwise I don't think it'll be possible to reference this hash from another location.
There was a problem hiding this comment.
Yeah, I'll turn that into a method
brucebolt
reviewed
Mar 18, 2021
We have these rules in four different apps so moving them to one place to make it easier to maintain.
MuriloDalRi
force-pushed
the
add-plural-rules-for-locales
branch
from
018af46
to
80e1c12
Compare
brucebolt
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have these rules in four different apps so moving them to one place
to make it easier to maintain.
https://trello.com/c/eEphXlio/2394-5-check-and-update-rules-for-plural-forms-across-frontend-apps