Implement RFC 141 - remove unsuitable healthchecks & return a 500 error on healthcheck failure #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are not suitable as healthchecks because they indicate a problem outside of the running app.
AlanGabbianelli
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC 141 proposes that healthchecks should be useful for load balancing, which means that they should only check if the app is (1) running and (2) ready to serve requests.
This PR implements the status code change. It also removes healthchecks which were deemed unsuitable for load balancing, as they indicate a problem outside of the app. Any apps which were using these checks now have separate Icinga alerts, if the check was valuable.
Trello card