Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix loading gem due missing PrometheusExporter constant #224

Merged
merged 4 commits into from
Mar 4, 2022
Merged

Fix loading gem due missing PrometheusExporter constant #224

merged 4 commits into from
Mar 4, 2022

Commits on Mar 4, 2022

  1. Fix issue with loading the GovukPrometheusExporter 

    There was a bug were the prometheus_exporter gem was incorrectly required
by the module. It was unable to find the top level module name
"PrometheusExporter" and need to be explicity required.
    @theseanything
    theseanything committed Mar 4, 2022
    Configuration menu
    Copy the full SHA
    c48028b View commit details
    Browse the repository at this point in the history

  2. Lazy load prometheus_exporter for GovukPrometheusExporter 

    This delays the require of prometheus_exporter until the configure
method is called. This prevents the library from being required by apps
the don't need it.
    @theseanything
    theseanything committed Mar 4, 2022
    Configuration menu
    Copy the full SHA
    8102852 View commit details
    Browse the repository at this point in the history

  3. Use GovukPrometheusExport for only Rails apps 

    The initialiser modules loads middleware into Rack and explicity depends
on Rails being present.
    @theseanything
    theseanything committed Mar 4, 2022
    Configuration menu
    Copy the full SHA
    866ff89 View commit details
    Browse the repository at this point in the history

  4. Bump version to 4.4.1

    @theseanything
    theseanything committed Mar 4, 2022
    Configuration menu
    Copy the full SHA
    540fa01 View commit details
    Browse the repository at this point in the history