Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gem name in warning message #243

Merged
merged 2 commits into from
May 20, 2022
Merged

Fix gem name in warning message #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3fcadaa
Fix gem name
ChrisBAshton May 20, 2022
bf8434f
Bump to 4.6.1
ChrisBAshton May 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# 4.6.1

- Fixes warning message to refer to correct Sidekiq gem dependency name ([#243](https://github.com/alphagov/govuk_app_config/pull/243)).

# 4.6.0

- Add a warning for apps using GovukError with Sidekiq that don't have sentry-sidekiq installed ([#241](https://github.com/alphagov/govuk_app_config/pull/241)).
Expand Down
2 changes: 1 addition & 1 deletion lib/govuk_app_config/govuk_error.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def self.configure
raise GovukError::AlreadyInitialised if is_configured?

if defined?(Sidekiq) && !defined?(Sentry::Sidekiq)
warn "Warning: GovukError is not configured to track Sidekiq errors, install the sidekiq-sentry gem to track them."
warn "Warning: GovukError is not configured to track Sidekiq errors, install the sentry-sidekiq gem to track them."
end

Sentry.init do |sentry_config|
Expand Down
2 changes: 1 addition & 1 deletion lib/govuk_app_config/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module GovukAppConfig
VERSION = "4.6.0".freeze
VERSION = "4.6.1".freeze
end