Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sidekiq Prometheus instrumentation #255

Merged
merged 1 commit into from
Aug 12, 2022
Merged

Conversation

fredericfran-gds
Copy link
Contributor

@fredericfran-gds fredericfran-gds commented Aug 3, 2022

Add Sidekiq Prometheus instrumentation
If Sidekiq is present, add the Sidekiq Prometheus instrumentation.

Ref:

  1. trello card

@fredericfran-gds fredericfran-gds changed the title testing Add Sidekiq Prometheus instrumentation Aug 5, 2022
If Sidekiq is present, add the Sidekiq Prometheus instrumentation.

Ref:
1. [trello card](https://trello.com/c/K8aUtwz4/974-graphs-for-sidekiq-queues-in-grafana)
@fredericfran-gds fredericfran-gds marked this pull request as ready for review August 8, 2022 15:45
Copy link

@kentsanggds kentsanggds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fredericfran-gds fredericfran-gds merged commit 48636bb into main Aug 12, 2022
@fredericfran-gds fredericfran-gds deleted the sidekiq_monitoring branch August 12, 2022 14:05
fredericfran-gds added a commit that referenced this pull request Aug 12, 2022
This will include #255 where Prometheus Sidekiq monitoring is
added.
@fredericfran-gds fredericfran-gds restored the sidekiq_monitoring branch August 12, 2022 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants