Allow us to force-load the Prometheus Exporter... #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Exporter currently ignores the `GOVUK_PROMETHEUS_EXPORTER` environment variable if it detects it is being called by rake. As the email-alerts-service is a perpetual rake task, we need a way to override this for the time being.
theseanything
previously approved these changes
Feb 20, 2023
theseanything
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The Exporter currently ignores the
GOVUK_PROMETHEUS_EXPORTERenvironment variable if it detects it is being called by rake.As the email-alerts-service is a perpetual rake task, we need a way to override this for the time being.
This should allow us to set the
GOVUK_PROMETHEUS_EXPORTERto"force"to make it configure the Prometheus Exporter regardless of whether it is being called byrakeor not.Related PRs