Allow prometheus binding to fail with a warning rather than a crash #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
KludgeKML
commented
May 10, 2023
KludgeKML
commented
- This allows us to (eg) run rake tasks or db migrations in situations where the port is already bound (for instance in a pod shell)
sengi
approved these changes
May 10, 2023
KludgeKML
force-pushed
the
allow-prometheus-fail
branch
from
b72ee74
to
dcff81c
Compare
- This allows us to (eg) run rake tasks or db migrations in situations where the port is already bound (for instance in a pod shell)
KludgeKML
force-pushed
the
allow-prometheus-fail
branch
2 times, most recently
from
cb06674
to
879d6be
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.