Prevent old logstasher monkey patch from overriding patch #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents the old monkey patch from being applied after the patch from this gem.
theseanything
requested review from
ChrisBAshton,
richardTowers,
dj-maisy and
kentsanggds
ChrisBAshton
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some apps the initialisation order means that the logstasher is initialiser after and therefore the original patch is applied after the patch from this library, effectively disabling the fix for OpenTelementry traces.
This sets the config option to prevent the logstasher from applying its patch after, if the original patch is already applied.