Merge pull request #3515 from alphagov/ga4-attachment-refactor

Move GA4 attachment link tracking to all attachment links

CHANGELOG.md

@@ -18,6 +18,7 @@
 * Add navigation-page-type GA4 pageview attribute ([PR #3529](https://github.com/alphagov/govuk_publishing_components/pull/3529))
 * Update the documentation for loading component stylesheets individually ([PR #3543](https://github.com/alphagov/govuk_publishing_components/pull/3543))
 * Add GA4 video tracking ([PR #3535](https://github.com/alphagov/govuk_publishing_components/pull/3535))
+* Move GA4 attachment link tracking to all attachment links ([PR #3515](https://github.com/alphagov/govuk_publishing_components/pull/3515))
 
 ## 35.13.1
 

app/views/govuk_publishing_components/components/_attachment.html.erb

@@ -43,8 +43,6 @@
       "HTML",
       class: "gem-c-attachment__attribute",
     )
-    data_attributes[:module] ? data_attributes[:module] << " ga4-link-tracker" : data_attributes[:module] = "ga4-link-tracker"
-    data_attributes[:ga4_link] = { "event_name": "navigation", "type": "attachment" }.to_json
   when "external"
     attributes << tag.span(
       attachment.url,
@@ -53,7 +51,7 @@
   end
 
 %>
-<%= tag.section class: class_names(container_class_names) do %>
+<%= tag.section class: class_names(container_class_names), data: { module: "ga4-link-tracker", ga4_track_links_only: "", ga4_link: { 'event_name': 'navigation', 'type': 'attachment' } } do %>
   <%= tag.div class: "gem-c-attachment__thumbnail" do %>
     <%= link_to attachment.url,
                 class: "govuk-link",

spec/components/attachment_spec.rb

@@ -269,19 +269,18 @@ def assert_thumbnail(type, src: nil)
     assert_select '.gem-c-attachment:not([class*="govuk-!-margin-bottom-"])'
   end
 
-  it "adds GA4 tracking on HTML attachment links" do
+  it "includes GA4 tracking on attachment links by default" do
     render_component(
       attachment: {
         title: "Test",
-        url: "https://assets.publishing.service.gov.uk/government/uploads/system/uploads/attachment_data/file/687542/February_2018_Consular_MI.csv",
+        url: "https://example.com",
         filename: "test",
         type: "html",
       },
     )
 
-    assert_select "h2 a[data-module=ga4-link-tracker]"
-    assert_select ".gem-c-attachment__thumbnail a[data-module=ga4-link-tracker]"
-    assert_select "h2 a[data-ga4-link='{\"event_name\":\"navigation\",\"type\":\"attachment\"}']"
-    assert_select ".gem-c-attachment__thumbnail a[data-ga4-link='{\"event_name\":\"navigation\",\"type\":\"attachment\"}']"
+    assert_select "section[data-module=ga4-link-tracker]"
+    assert_select "section[data-ga4-link='{\"event_name\":\"navigation\",\"type\":\"attachment\"}']"
+    assert_select "section[data-ga4-track-links-only]"
   end
 end