Add a reset option into the GA4 scrolltracker #3544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysellick
force-pushed
the
scrolltracker-reset
branch
from
2955946
to
8676866
Compare
andysellick
added a commit
to alphagov/finder-frontend
that referenced
this pull request
Aug 10, 2023
- if listening, the scroll tracker will detect this event and reset scroll tracking - see related PR: alphagov/govuk_publishing_components#3544
- code adds an event listener for 'dynamic-page-update' event, which resets all of the nodes to alreadySeen = false - this event can then be triggered by code elsewhere, in order to 'reset' scroll tracking on any given page - initial use is for search pages, where users change their search filters, page dynamically updates and so scroll tracking only works the first time, now if the search code triggers that event, the scroll tracker will reset
andysellick
force-pushed
the
scrolltracker-reset
branch
from
8676866
to
2bdaa3f
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
Scroll tracking works correctly on search pages until users change their filters. At that point the user is effectively on a new page (content and URL change) and we want the scroll tracking to 'reset' (i.e. if the user has scrolled to the bottom of the page previously, we want to also record that happened after the search filters are changed). Unfortunately because the page was updated dynamically using JS, the scroll tracker still thinks its on the same page, and therefore doesn't register GA4 events when users scroll. This PR fixes that - a related PR will be raised in
finder-frontendto add to required event trigger.Visual Changes
None.
Trello card: https://trello.com/c/fhnLqnKw/669-scroll-tracker-to-refresh-on-dynamic-pages