Update and/or add component print styles #4073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthillco
force-pushed
the
update-component-print-styles
branch
from
5e63d9f
to
06cf355
Compare
matthillco
force-pushed
the
update-component-print-styles
branch
from
930c3b8
to
f63e290
Compare
matthillco
force-pushed
the
update-component-print-styles
branch
from
c851c24
to
ad211df
Compare
|
Note that while this can be code reviewed, it has not yet been design reviewed (which may produce further code changes). |
matthillco
force-pushed
the
update-component-print-styles
branch
from
ad211df
to
e47eaa8
Compare
AshGDS
reviewed
Jul 25, 2024
app/assets/stylesheets/govuk_publishing_components/components/_heading.scss
Show resolved
Hide resolved
app/assets/stylesheets/govuk_publishing_components/components/_intervention.scss
Show resolved
Hide resolved
app/assets/stylesheets/govuk_publishing_components/components/_lead-paragraph.scss
Show resolved
Hide resolved
app/assets/stylesheets/govuk_publishing_components/components/_metadata.scss
Show resolved
Hide resolved
app/assets/stylesheets/govuk_publishing_components/components/_phase-banner.scss
Outdated
Show resolved
Hide resolved
app/views/govuk_publishing_components/components/_contextual_breadcrumbs.html.erb
Show resolved
Hide resolved
app/assets/stylesheets/govuk_publishing_components/components/_breadcrumbs.scss
Outdated
Show resolved
Hide resolved
app/assets/stylesheets/govuk_publishing_components/components/_tabs.scss
Outdated
Show resolved
Hide resolved
app/assets/stylesheets/govuk_publishing_components/components/_layout-header.scss
Outdated
Show resolved
Hide resolved
matthillco
force-pushed
the
update-component-print-styles
branch
from
e47eaa8
to
61584ff
Compare
matthillco
force-pushed
the
update-component-print-styles
branch
from
61584ff
to
6fae083
Compare
matthillco
force-pushed
the
update-component-print-styles
branch
from
6fae083
to
91197ce
Compare
- Add individual_component_support to allow `govuk-media-query` to work - Set printed url to inherit parent font-size. This component can have different text sizes depending on how it’s used and the printed url should follow the same text size. - Set printed url to inherit parent colour. This ensures we print in black which has better printed contrast than blue and is potentially cheaper (black ink is cheaper than mixing colour inks).
- colours now print black on white - remove all auto margins to improve layout - remove unnecessary padding - improve border styling for print - remove all links
matthillco
force-pushed
the
update-component-print-styles
branch
from
dc11505
to
a0e35b0
Compare
Merged
This was referenced Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR updates the print styles for any public-facing components. The changes broadly fall into these categories:
Trello card
Why
People still print a lot of pages from GOV.UK. And recent discussions have highlighted potential problems, or at least a perception that HTML pages when printed aren't as good as PDFs. We're trying to move away from/discourage the use of PDFs on GOV.UK, so improving the print experience could help.
Visual Changes
There are too many differences to include all before/after shots here. Changes will be reviewed with a designer before deployment.