Add accessible-autocomplete node_modules to gemspec
#4246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csutter
changed the title
accessible-autocomplete to gemspecaccessible-autocomplete node modules to gemspec
This was missing from the gemspec's file allowlist, causing it to not be included in the gem archive published to Rubygems.
csutter
force-pushed
the
fix-gem-build
branch
from
4455c6e
to
e2dbd29
Compare
csutter
changed the title
accessible-autocomplete node modules to gemspecaccessible-autocomplete node_modules to gemspec
andysellick
approved these changes
Sep 20, 2024
Merged
ChrisBAshton
added a commit
to alphagov/whitehall
that referenced
this pull request
Sep 26, 2024
This is the last known working version of the dependency. In bumping to 43.4.1 (in #9463), Whitehall components driven by JS broke. Namely: choosing organisations, tagging ministers, etc. It appears to be something to do with how the changes in alphagov/govuk_publishing_components#4246 are incompatible with Whitehall's own accessible-autocomplete implementation. Until we have time to look into this properly, let's pin to the last known working version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was missing from the gemspec's file allowlist, causing it to not be included in the gem archive published to Rubygems.