Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add component wrapper helper to error alert component #4287

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

AshGDS
Copy link
Contributor

@AshGDS AshGDS commented Oct 7, 2024

What / Why

Visual Changes

None.

@AshGDS AshGDS self-assigned this Oct 7, 2024
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4287 October 7, 2024 14:20 Inactive
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4287 October 7, 2024 14:27 Inactive
@AshGDS AshGDS force-pushed the error-alert-component-wrapper branch from 5f023a3 to 73c2f22 Compare October 7, 2024 14:27
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4287 October 7, 2024 14:28 Inactive
@AshGDS AshGDS marked this pull request as ready for review October 7, 2024 14:42
Copy link
Contributor

@andysellick andysellick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one confusion.

@AshGDS AshGDS force-pushed the error-alert-component-wrapper branch from 73c2f22 to 1161883 Compare October 22, 2024 13:18
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4287 October 22, 2024 13:18 Inactive
@AshGDS AshGDS merged commit 077e43e into main Oct 22, 2024
12 checks passed
@AshGDS AshGDS deleted the error-alert-component-wrapper branch October 22, 2024 13:21
@andysellick andysellick mentioned this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants