Add shared helper and component wrapper helper to govspeak component #4325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysellick
force-pushed
the
add-helpers-to-govspeak
branch
from
4b4577e
to
72acf2f
Compare
- to govspeak - mainly to be able to pass a margin option to the component, but also because the component wrapper works well here - involves renaming a few classes to allow them to be passed to the component wrapper, specifically the disable youtube (adding a JS prefix) and direction-rtl (add a gem-c-govspeak prefix) otherwise the wrapper raises an error
andysellick
force-pushed
the
add-helpers-to-govspeak
branch
from
72acf2f
to
55efc20
Compare
AshGDS
approved these changes
Oct 21, 2024
This was referenced Oct 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds the
shared_helperandcomponent wrapper helperto the govspeak component.Involves renaming a few classes to allow them to be passed to the component wrapper, specifically the disable youtube (adding a JS prefix) and direction-rtl (add a gem-c-govspeak prefix) otherwise the wrapper raises an error.
Why
Mainly so we can pass a margin option to the component, but also because the component wrapper works well here.
Visual Changes
Shouldn't be any visual changes, but the component guide has a few new options listed, so this will cause a Percy fail.
Trello card: https://trello.com/c/YAeRSLr4/91-blocks-need-more-spacing