Update brakeman to fix false positive warning #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barrucadu
reviewed
Jun 8, 2021
AlanGabbianelli
changed the title
AlanGabbianelli
force-pushed
the
upgrade-brakeman
branch
from
257955a
to
4f2a737
Compare
We recently came across a [strange warning][0] in a `frontend` build: ``` == Warnings == Confidence: High Category: Cross-Site Scripting Check: SanitizeMethods Message: loofah gem 2.10.0 is vulnerable (CVE-2018-8048). Upgrade to 2.2.1 File: Gemfile.lock Line: 187 ``` Version 2.10.0 is clearly more recent than 2.2.1. This came from how brakeman was doing a check: ``` loofah_version and loofah_version < "2.2.1" ``` but in ruby `'2.10.0' < '2.2.1'` is true: ``` [2] pry(main)> '2.10.0' < '2.2.1' => true ``` This [has been fixed][1] in [version 5.0.2][2] so let's upgrade brakeman to this new version. [0]: https://ci.integration.publishing.service.gov.uk/job/frontend/job/update-rubocop/6/console [1]: https://github.com/presidentbeef/brakeman/pull/1607/files [2]: https://github.com/presidentbeef/brakeman/blob/main/CHANGES.md#502---2021-06-07
AlanGabbianelli
force-pushed
the
upgrade-brakeman
branch
from
b6777e2
to
9e9e561
Compare
barrucadu
approved these changes
Jun 8, 2021
barrucadu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently came across a strange warning in a
frontendbuild:Version 2.10.0 is clearly more recent than 2.2.1. This came from how
brakeman was doing a check:
but in ruby
'2.10.0' < '2.2.1'is true:This has been fixed in version 5.0.2 so let's upgrade brakeman to
this new version.