Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using webdrivers gem #43

Merged
merged 2 commits into from
Mar 7, 2022
Merged

Stop using webdrivers gem #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50ed673
Stop using webdrivers gem
ollietreend Feb 25, 2022
03ca912
Release version 3.0.0
ollietreend Feb 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@
useful summary for people upgrading their application, not a replication
of the commit log.

## 3.0.0

* BREAKING: Remove dependency on `webdrivers` gem. It's now expected that ChromeDriver is present on the underlying operating system. ([#43](https://github.com/alphagov/govuk_test/pull/43))

## 2.3.0

* Update brakeman to fix false positive warning ([#41](https://github.com/alphagov/govuk_test/pull/41))
Expand Down
1 change: 0 additions & 1 deletion govuk_test.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ Gem::Specification.new do |spec|
spec.add_dependency "capybara"
spec.add_dependency "puma"
spec.add_dependency "selenium-webdriver", ">= 3.142"
spec.add_dependency "webdrivers", ">= 4"

spec.add_development_dependency "bundler"
spec.add_development_dependency "climate_control"
Expand Down
8 changes: 0 additions & 8 deletions lib/govuk_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,6 @@
require "puma"
require "selenium-webdriver"

unless ENV["GOVUK_TEST_USE_SYSTEM_CHROMEDRIVER"]
require "webdrivers"

# This stop webdrivers doing a lazy check for new versions
# of chromedriver, which interferes with WebMock.disable_net_connect
Selenium::WebDriver::Chrome::Service.driver_path = Webdrivers::Chromedriver.update
end

module GovukTest
def self.configure
Capybara.register_driver :headless_chrome do |app|
Expand Down
2 changes: 1 addition & 1 deletion lib/govuk_test/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module GovukTest
VERSION = "2.3.0"
VERSION = "3.0.0"
end