Replace deprecated headless! option
#63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This Selenium blog post from 29 Jan 2023[1] explains that the
`headless!` convenience method is being deprecated. There are now 2
headless modes in Chromium so we should use the arguments to browser
options to define the mode we want.
The deprecation message reads:
> 2023-10-09 11:12:07 WARN Selenium [:headless] [DEPRECATION]
> `Options#headless!` is deprecated. Use
> `Options#add_argument('--headless=new')` instead.
Although it says to use `--headless=new`, I've chosen to switch to
`--headless` in this commit as this retains the existing behaviour of
`headless!`. You can verify this in the diff of the commit that removes
the deprecated `headless!` method[2].
[1]: https://www.selenium.dev/blog/2023/headless-is-going-away/
[2]: SeleniumHQ/selenium@0fa6c3f
This was referenced Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Selenium blog post from 29 Jan 2023 explains that the
headless!convenience method is being deprecated. There are now 2 headless modes in Chromium so we should use the arguments to browser options to define the mode we want.The deprecation message reads:
Although it says to use
--headless=new, I've chosen to switch to--headlessin this commit as this retains the existing behaviour ofheadless!. You can verify this in the diff of the commit that removes the deprecatedheadless!method.