Get logit pipeline building working #3227
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yep, this is janky and gross openjdk doesn't work properly when run through qemu (x86 on arm64): docker/for-mac#6060 Instead, build an image from the last 9.2 Dockerfile from the jruby git history (before it was removed).
whi-tw
force-pushed
the
fix-logit-pipeline-building
branch
from
926ada6
to
bc14ed3
Compare
fearoffish
approved these changes
Jun 26, 2023
AP-Hunt
approved these changes
Jun 26, 2023
Just about to test it on a amd64 ubuntu box. stand by. Update: it works |
AP-Hunt
added a commit
that referenced
this pull request
Jun 26, 2023
Get logit pipeline building working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Make it so we can build the logit pipelines again.
Yep, this is janky and gross
openjdk doesn't work properly when run through qemu (x86 on arm64):
docker/for-mac#6060
Instead, build an image from the last 9.2 Dockerfile from the jruby git
history (before it was removed).
How to review
🚨⚠️ Please do not merge this pull request via the GitHub UI ⚠️ 🚨