Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable dms validation and enable awsdms_txn_state table #3229

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Disable dms validation and enable awsdms_txn_state table #3229

merged 1 commit into from
Jun 21, 2023

Conversation

corlettb
Copy link
Contributor

What

DMS default config changes:

  • Disable dms validation.
  • Enable awsdms_txn_state table.
  • Enabled StopTaskCachedChangesNotApplied.

Why

  • The validation doesn't work across all tables correctly when loading data without primary keys. We have proved validation anyway so we can disable.
  • The awsdms_txn_state table can give us more regular updates on the state of the replication.
  • We are enabling the StopTaskCachedChangesNotApplied option so we have a clear point to apply our primary keys, indices and constraints before the cdc process starts.

How to review

Look at the changes.

🚨⚠️ Please do not merge this pull request via the GitHub UI ⚠️🚨

@corlettb
DMS default config changes:
cf9938a 
- Disable dms validation.
- Enable awsdms_txn_state table.
- Enabled StopTaskCachedChangesNotApplied so that primary keys, indices and constraints can be applied after the stop.
@corlettb corlettb marked this pull request as ready for review June 19, 2023 08:23
jackjoy-gds
jackjoy-gds approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@jackjoy-gds jackjoy-gds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corlettb corlettb merged commit 75c0b4b into main Jun 21, 2023
8 checks passed
@corlettb corlettb deleted the dms_tweaks branch June 21, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackjoy-gds jackjoy-gds jackjoy-gds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corlettb @jackjoy-gds