create-concourse: add nonadmin user creation, use for billing acceptance tests #3232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there isn't really anything admin-specific about this
…ceptance tests using existing create_admin task. this is a bit safer as the temp admin will be deleted following the test, invalidating any potential cred leaks.
risicle
force-pushed
the
ris-billing-test-expansion
branch
from
0cc816f
to
4734ed7
Compare
…ance tests this also optionally makes the user a billing manager of a specified org. not combined with create_admin as the two are created in fundamentally different ways.
risicle
force-pushed
the
ris-billing-test-expansion
branch
from
4734ed7
to
ec1be0a
Compare
AP-Hunt
reviewed
Jun 23, 2023
AP-Hunt
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
https://www.pivotaltracker.com/story/show/185167233
This expands the way we create/delete temporary cf users in the
create-cloudfoundrypipeline to also be able to create non-admin users (which can optionally be made a billing manager of a named org).It then uses both admin and non-admin accounts generated this way for the billing acceptance tests.
How to review
Deploy to a dev env, see existing acceptance tests passing and billing acceptance tests passing following a deploy.
🚨⚠️ Please do not merge this pull request via the GitHub UI ⚠️ 🚨