Allow external redirects to caa.co.uk #2510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The validation error message was hardcoded and no longer reflected the full list of allowed domains. This confused me when trying to debug a failing external redirect because I expected the error message to list all the allowed domains. I've made this error message dynamic so it always reflects the current allow list. Before: external redirects only accepted within the gov.uk, judiciary.uk, nhs.uk or ukri.org domains After: external redirects only accepted for the domains .gov.uk, .judiciary.uk, .nationalhighways.co.uk, .nhs.uk, .police.uk, and .ukri.org
This allows users to unpublish documents and redirect it to URLs on the Civil Aviation Authority (CAA) website. Requested in Zendesk ticket: https://govuk.zendesk.com/agent/tickets/4994883 And agreed in Slack thread: https://gds.slack.com/archives/CACV3TACU/p1694690016148749 I originally added this to Whitehall in PR alphagov/whitehall#8290 before realising that the document to be unpublished & redirected is actually published via Specialist Publisher, and therefore this is actually where the list needs updating. 🙈
ollietreend
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to unpublish documents and redirect it to URLs on the Civil Aviation Authority (CAA) website.
Requested in Zendesk ticket:
https://govuk.zendesk.com/agent/tickets/4994883
And agreed in Slack thread:
https://gds.slack.com/archives/CACV3TACU/p1694690016148749
I originally added this to Whitehall in PR alphagov/whitehall#8290 before realising that the document to be unpublished & redirected is actually published via Specialist Publisher, and therefore this is actually where the list needs updating. 🙈
This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.