Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove specialist topic code from Publishing API #2669

Closed
wants to merge 19 commits into from
Closed

Remove specialist topic code from Publishing API #2669

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
bf0fa5f
Remove topic taxonomy taxons
unoduetre Mar 14, 2024
b155257
Remove topic taxonomy taxons (dist)
unoduetre Mar 14, 2024
234c0ee
Remove links to topics
unoduetre Mar 14, 2024
00f784c
Remove links to topics (dist)
unoduetre Mar 14, 2024
a624df0
Remove topic content schema
unoduetre Mar 14, 2024
2f69bb1
Remove topic content schema (dist)
unoduetre Mar 14, 2024
ad572f9
Remove topics from email alert types
unoduetre Mar 14, 2024
2a8893b
Remove topics from email alert types (dist)
unoduetre Mar 14, 2024
ddaf127
Remove topic tags
unoduetre Mar 14, 2024
513f78f
Remove topic tags (dist)
unoduetre Mar 14, 2024
e20c58c
Fix specs other than Pact specs
unoduetre Mar 15, 2024
ac09a5a
Revert removing topic taxonomy taxons
unoduetre Mar 15, 2024
09d159a
Revert removing topic taxonomy taxons (dist)
unoduetre Mar 15, 2024
f7ba0ff
Fix Pact specs
unoduetre Mar 15, 2024
1ec47ae
Remove specialist topics from database
unoduetre Mar 14, 2024
aab4de5
Merge branch 'main' into 2417-remove-specialist-topic-code-from-publi…
unoduetre Mar 15, 2024
97884ee
Remove topic from allowed_document_types.yml
unoduetre Mar 15, 2024
524c8ba
Fix after merging main
unoduetre Mar 15, 2024
e684811
Remove topic from allowed_document_types.yml (dist)
unoduetre Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions lib/schema_generator/expanded_links.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,6 @@ class ExpandedLinks
# to by the `pages_related_to_step_nav` link type
"related_to_step_navs" => "frontend_links_with_base_path",

# Taxons that have been created by merging old 'legacy' taxons will have
# a reverse link to determine where the replacement Topic Taxonomy taxon
# now resides
"topic_taxonomy_taxons" => "frontend_links_with_base_path",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds like topic_taxonomy_taxons were to do with mapping specialist topics to taxonomy topics, so I think it's fair to assume that this field is no longer required. It also looks like this attribute isn't being used in the publishing apps or in the frontend apps anyhow 👍

So let's cherry pick bf0fa5f and b155257 into a fresh PR. Linking to that grep in the commit message/PR description, so that it's easy to review and merge with confidence that nothing will break.


# Step by steps that a content items may be a part of but is not essential
# to completing it.
"secondary_to_step_navs" => "frontend_links_with_base_path",
Expand Down