Remove topics from base_links and whitehall_edition_links #2678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannako
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Once the change in government frontend unblocks the failing CI here this looks good @unoduetre
@brucebolt topics are no longer being added to links in publisher, whitehall or content tagger. And as all specialist topics have now been unpublished, I would not expect any live content items to contain a link to a topic. But is there anyway to check this latter point? Or is it not worth worrying about?
unoduetre
force-pushed
the
2417-remove-specialist-topic-code-from-publishing-api-l-2
branch
from
bdd79be
to
add6783
Compare
jkempster34
approved these changes
Mar 27, 2024
unoduetre
deleted the
2417-remove-specialist-topic-code-from-publishing-api-l-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.
Part of 🏔Epic | Remove specialist topic code from Publishing API [L]EPICS 🌀
What
Remove topics from the two different types of links defined in publishing API. This work might be worth splitting into two PR’s, one for each link type.
Why
We’ve retired all specialist topics, so in theory there should be no content items that contain a link to a specialist topic anymore.
Trello card
How
Follow https://github.com/alphagov/publishing-api/blob/main/docs/content_schemas/changing-an-existing-content-schema.md#removing-a-field-from-a-content-schema