Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retire topic schema #2679

Merged

Conversation

unoduetre
Copy link
Contributor

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.

Follow these steps if you are doing a Rails upgrade.

Part of https://trello.com/c/2LcbNRSQ/2417-%F0%9F%8F%94epic-remove-specialist-topic-code-from-publishing-api-l

What

Remove the topic schema from publishing API
Trello card

Why

We’ve retired specialist topics

@unoduetre unoduetre marked this pull request as ready for review March 18, 2024 13:36
@unoduetre unoduetre force-pushed the 2417-remove-specialist-topic-code-from-publishing-api-l-3 branch from fbaf077 to 922f70a Compare March 18, 2024 15:51
Copy link
Contributor

@hannako hannako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good @unoduetre (Once you've resolved the conflict)

There are no live topic pages anymore so this should be safe to merge, once publishing devs have given the thumbs up.

The file in this commit from the dist directory has been regenerated
by running "bundle exec rake build_schemas".
@unoduetre unoduetre force-pushed the 2417-remove-specialist-topic-code-from-publishing-api-l-3 branch from 922f70a to 6b9cb8c Compare April 2, 2024 10:36
Copy link
Contributor

@JonathanHallam JonathanHallam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you :)

@unoduetre unoduetre merged commit bfa7931 into main Apr 8, 2024
43 checks passed
@unoduetre unoduetre deleted the 2417-remove-specialist-topic-code-from-publishing-api-l-3 branch April 8, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants