Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop requirement from ~> 1.7.0 to ~> 1.10.0 #127

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

dependabot-preview[bot]
Copy link
Contributor

Updates the requirements on rubocop to permit the latest version.

Release notes

Sourced from rubocop's releases.

RuboCop 1.10

New features

  • #9478: Add new Style/HashConversion cop. (@zverok)
  • #9496: Add new Gemspec/DateAssignment cop. (@koic)
  • #8724: Add IgnoreModules configuration to Style/ConstantVisibility to not register offense for module definitions. (@tejasbubane)
  • #9403: Add autocorrect for Style/EvalWithLocation cop. (@cteece)

Bug fixes

  • #9500: Update Lint/Debugger so that only specific receivers for debug methods lead to offenses. (@dvandersluis)
  • #9499: Fix a false positive for Layout/SpaceBeforeBrackets when multiple spaces are inserted inside the left bracket. (@koic)
  • #9507: Fix an incorrect auto-correct for Lint/RedundantSplatExpansion when expanding Array.new call on method argument. (@koic)
  • #9490: Fix incorrect auto-correct for Layout/FirstArgumentIndentation when specifying EnforcedStyle: with_fixed_indentation of Layout/ArgumentAlignment and EnforcedStyle: consistent of Layout/FirstArgumentIndentation. (@koic)
  • #9497: Fix an error for Style/ExplicitBlockArgument when yield is inside block of super. (@koic)
  • #9349: Fix a false positive for Lint/MultipleComparison when using &, |, and ^ set operation operators in multiple comparison. (@koic)
  • #9511: Fix a false negative for Lint/ElseLayout when using multiple elsifs. (@koic)
  • #9513: Fix an incorrect auto-correct for Style/HashConversion when using hash argument Hash[]. (@koic)
  • #9492: Fix an incorrect auto-correct for Lint/DeprecatedOpenSSLConstant when using no argument algorithm. (@koic)

Changes

Changelog

Sourced from rubocop's changelog.

1.10.0 (2021-02-15)

New features

  • #9478: Add new Style/HashConversion cop. ([@zverok][])
  • #9496: Add new Gemspec/DateAssignment cop. ([@koic][])
  • #8724: Add IgnoreModules configuration to Style/ConstantVisibility to not register offense for module definitions. ([@tejasbubane][])
  • #9403: Add autocorrect for Style/EvalWithLocation cop. ([@cteece][])

Bug fixes

  • #9500: Update Lint/Debugger so that only specific receivers for debug methods lead to offenses. ([@dvandersluis][])
  • #9499: Fix a false positive for Layout/SpaceBeforeBrackets when multiple spaces are inserted inside the left bracket. ([@koic][])
  • #9507: Fix an incorrect auto-correct for Lint/RedundantSplatExpansion when expanding Array.new call on method argument. ([@koic][])
  • #9490: Fix incorrect auto-correct for Layout/FirstArgumentIndentation when specifying EnforcedStyle: with_fixed_indentation of Layout/ArgumentAlignment and EnforcedStyle: consistent of Layout/FirstArgumentIndentation. ([@koic][])
  • #9497: Fix an error for Style/ExplicitBlockArgument when yield is inside block of super. ([@koic][])
  • #9349: Fix a false positive for Lint/MultipleComparison when using &, |, and ^ set operation operators in multiple comparison. ([@koic][])
  • #9511: Fix a false negative for Lint/ElseLayout when using multiple elsifs. ([@koic][])
  • #9513: Fix an incorrect auto-correct for Style/HashConversion when using hash argument Hash[]. ([@koic][])
  • #9492: Fix an incorrect auto-correct for Lint/DeprecatedOpenSSLConstant when using no argument algorithm. ([@koic][])

Changes

1.9.1 (2021-02-01)

New features

  • #9459: Add AllowedMethods option to Style/IfWithBooleanLiteralBranches and set nonzero? as default value. ([@koic][])

Bug fixes

  • #9431: Fix an error for Style/DisableCopsWithinSourceCodeDirective when using leading source comment. ([@koic][])
  • #9444: Fix error on colorization for offenses with Severity: info. ([@tejasbubane][])
  • #9448: Fix an error for Style/SoleNestedConditional when using nested unless modifier with a single expression condition. ([@koic][])
  • #9449: Fix an error for Style/NilComparison when using x == nil as a guard condition'. ([@koic][])
  • #9440: Fix Lint/SymbolConversion for implicit to_sym without a receiver. ([@dvandersluis][])
  • #9453: Fix infinite loop error for Layout/FirstParameterIndentation when EnforcedStyle: with_fixed_indentation is specified for Layout/ArgumentAlignment. ([@koic][])
  • #9466: Don't correct Style/SingleLineMethods using endless methods if the target ruby is < 3.0. ([@dvandersluis][])
  • #9455: Fix a false positive for Lint/SymbolConversion when hash keys that contain ":". ([@koic][])
  • #9454: Fix an incorrect auto-correct for Style/IfWithBooleanLiteralBranches when using elsif do_something? with boolean literal branches. ([@koic][])
  • #9438: Fix a false positive for Layout/SpaceBeforeBrackets when space is used in left bracket. ([@koic][])
  • #9457: Fix a false positive for Lint/SymbolConversion when hash keys that end with =. ([@koic][])
  • #9473: Fix an error for Lint/DeprecatedConstants when using __ENCODING__. ([@koic][])
  • #9452: Fix StyleGuideBaseURL not functioning with nested departments. ([@tas50][])
  • #9465: Update Metrics/ParameterLists to be able to write MaxOptionalParameters in rubocop_todo.yml. ([@dvandersluis][])
  • #9433: Fix an error for Style/EvalWithLocation when using eval with block argument. ([@koic][])

Changes

... (truncated)

Commits
  • 9e8a5ee Cut 1.10
  • 53d8723 Update Changelog
  • dcd8b7d Upgrade rubocop-rspec
  • 708eb90 Fix RSpec/StubbedMock offenses
  • fcb3a94 Improve documentation for Style/EvalWithLocation cop
  • 6cdce3b Add IgnoreModules configuration to Style/ConstantVisibility
  • 07cd64c [Fix #9349] Fix a false positive for Lint/MultipleComparison
  • 7e89008 [Fix #9513] Fix an incorrect auto-correct for Style/HashConversion
  • 2d3e1bc [Fix #9403] Add autocorrect for Style/EvalWithLocation
  • b2aa853 Fix a false negative for Lint/ElseLayout
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added the dependencies Pull requests that update a dependency file label Feb 16, 2021
@kevindew kevindew force-pushed the dependabot/bundler/rubocop-gte-1.7-and-lt-1.11 branch 2 times, most recently from ac7cf56 to 80f9e48 Compare February 16, 2021 18:10
@kevindew
Copy link
Member

This seems like an ok change to go in. The new rules added don't look particularly problematic or divisive. If it turns out some are we're already planning to do a pre-release of the next version where this should be revealed.

The new rules are:

  • #9478: Add new Style/HashConversion cop.
  • #9496: Add new Gemspec/DateAssignment cop.
  • #9396: Add new Style/IfWithBooleanLiteralBranches cop.
  • #9402: Add new Lint/TripleQuotes cop.
  • #9353: Add new Lint/SymbolConversion cop.
  • #9363: Add new cop Lint/OrAssignmentToConstant.
  • #9326: Add new Lint/NumberedParameterAssignment cop.
  • #9324: Add new Lint/DeprecatedConstants cop.
  • #9301: Add new Lint/RedundantDirGlobSort cop.
  • #9281: Add new cop Style/EndlessMethod.
  • #9321: Add new Lint/LambdaWithoutLiteralBlock cop.

@kevindew kevindew changed the title Update rubocop requirement from ~> 1.7.0 to >= 1.7, < 1.11 Update rubocop requirement from ~> 1.7.0 to ~> 1.10.0 Feb 16, 2021
@kevindew kevindew force-pushed the dependabot/bundler/rubocop-gte-1.7-and-lt-1.11 branch from 80f9e48 to c9b5038 Compare February 16, 2021 18:20
Base automatically changed from master to main February 16, 2021 18:22
Copy link
Contributor

@benthorner benthorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for listing them all out - made it much easier to review 🎖️. I think these are good as well, particularly the ones that emulate v3 warnings.

The only one I (personally) dislike is Lint/SymbolConversion, as it's not clear why :'string' is so much better / clearer than 'string'.to_sym. I'd say the latter is more explicit, and thus easier to read. But I don't think it's a major issue.

@kevindew
Copy link
Member

Thanks for listing them all out - made it much easier to review 🎖️. I think these are good as well, particularly the ones that emulate v3 warnings.

The only one I (personally) dislike is Lint/SymbolConversion, as it's not clear why :'string' is so much better / clearer than 'string'.to_sym. I'd say the latter is more explicit, and thus easier to read. But I don't think it's a major issue.

Oh yeah - that one hadn't really caught my attention. Yeah I don't think it'll be a big concern, I find myself somewhat agreeing with your point but also feeling like using :"kebab-case" is a more common approach for converting unsafe characters to symbols.

@kevindew kevindew merged commit 0bbc40a into main Feb 18, 2021
@kevindew kevindew deleted the dependabot/bundler/rubocop-gte-1.7-and-lt-1.11 branch February 18, 2021 12:54
@kevindew kevindew mentioned this pull request Feb 19, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants