Content modelling/550 fix cache busting #9459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harriethw
force-pushed
the
content-modelling/550-fix-cache-busting
branch
3 times, most recently
from
0bc6411
to
6c4f1dc
Compare
Now that this PR is merged [1] we should be able to retrieve the name of the publishing app for Host Content. We will shortly use this when creating Publish Intents to remove the cache when updating Host Documents. [1] alphagov/publishing-api#2876
we want to send Publish Intents for Host Content (e.g. Editions that are using embedded content/Content Blocks) [1] that is published by other apps - this allows an optional app to be passed in, but retains the default Whitehall value in order not to break existing functionality. [1] #9447
We want to remove the cache Host Content that is not published by Whitehall, as embedded content can be used across all Publishing apps. [1] alphagov/publishing-api#2876
Harriethw
force-pushed
the
content-modelling/550-fix-cache-busting
branch
from
6c4f1dc
to
d1c3824
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this previous PR #9447 we sent Publish Intents for Host Content, but hardcoded Whitehall as the publishing app - this means jobs for Documents published on other apps will fail.
This PR gets the publishing app from a Host Content Item (added here alphagov/publishing-api#2876) and ensures it is passed along when creating the Publish Intent.