-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mask plugin with data directive (CSP) #4090
base: main
Are you sure you want to change the base?
Conversation
I can't figure out what causes the breaking tests really :) Help appreciated 🙏 This is the last bit of a huge CSP re-write, to deploy our new app to production :) |
I think the improved API would probably be actually binding the function to an object with the scope/magics... also not sure why it causes an issue with the failed tests...but definitely need to figure that one out... |
not following a 100% :) do you mean passing this as the 2nd argument instead? 🤔
or
🤔 |
more like value.bind({ $input: input, $money: formatMoney.bind({el}) })(input) But also whatever would make |
Yea, i just came across that issue. |
Well, I just showed....bind the value... |
Sorry, i spoke too soon :P
basically im doing something like
where thanks for you continuing support! 🙏 |
You can possibly look at how magics are injected into the state in the first place, or use mergeProxies directly to layer them. |
Before:
Data directive:
HTML:
After
Data directive:
HTML:
Let me know if I'm missing something, or if it would break something else?
It does work in our app's UI tho.